[Bug 196185] emulators/hyperv-is: Update Hyper-v ports for FreeBSD 10.1

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags| |maintainer-feedback?(bsdic@
| |microsoft.com)
Keywords| |needs-patch
Summary|Update Hyper-v ports for |emulators/hyperv-is: Update
|FreeBSD 10.1 to include new |Hyper-v ports for FreeBSD
|features and bug fixes |10.1

--- Comment #1 from Kubilay Kocak <***@FreeBSD.org> ---
Maintainer CC'd

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

Kubilay Kocak <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|emulators/hyperv-is: Update |emulators/hyperv-is: Update
|Hyper-v ports for FreeBSD |Hyper-V ports for FreeBSD
|10.1 |10.1

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

Xin LI <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Flags|maintainer-feedback?(bsdic@ |maintainer-feedback+
|microsoft.com) |

--- Comment #2 from Xin LI <***@FreeBSD.org> ---
This was submitted by maintainer.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #3 from Xin LI <***@FreeBSD.org> ---
(In reply to Kylie from comment #0)

There are below new feature and critical bug fix to get FreeBSD running on
Hyper-v.
1) Scatter/gather I/O for storage
2) KVP does not work on windows server 2008 R2

Hrm I can't seem to find the patch for this, could you please attach it to this
ticket?

Thanks!

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #4 from Kylie <***@microsoft.com> ---
Jun, please attach patch here.

Hi Xin,

Ports are available for all new releases. However when 10.2 is released, we may
already get everything upstreamed and nothing is needed for 10.2. Then for
10.2, how to exit gracefully without error message if somebody still tries to
run our ports.
We could add one message to say "no more update for 10.2" but ERROR will still
be printed if we exits ports with "IGNORE" signal.

Thanks,
Kylie Liang

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #5 from FangJun <***@hotmail.com> ---
Created attachment 150893
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=150893&action=edit
patch

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #6 from FangJun <***@hotmail.com> ---
Created attachment 150894
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=150894&action=edit
/usr/ports/emulator/hyperv-is

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #7 from Kylie <***@microsoft.com> ---
Andy is doing internal testing. Once done, please update the bugzilla to move
forward.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #8 from FangJun <***@hotmail.com> ---
Created attachment 151487
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151487&action=edit
update hyperv-is.shar 2015-01-08

update hyperv-is.shar 2015-01-08

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #9 from FangJun <***@hotmail.com> ---
Created attachment 151488
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151488&action=edit
hyperv-is diff

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

andy zhang <***@hotmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@hotmail.com

--- Comment #8 from andy zhang <***@hotmail.com> ---
Created attachment 151525
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=151525&action=edit
10.1 ports code

already tested in 10.1, 10.0, 9.x, 8.x

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

John Marino <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@FreeBSD.org

--- Comment #9 from John Marino <***@FreeBSD.org> ---
This is a patch to the source code, not a patch to the port.

I see the last attachment is a "shar" of the entire port. In theory patches
could be generated by comparing that to the current port.

However, submitting "shar" instead of patches is not easy for anybody.

Actually, these three attachments are causing me a great deal of confusion.

Attachment 1: patch, Dec 23, seems to patch source
Attachment 2: patch, Dec 23, seems to patch port but doesn't reference
attachment 1 patch
Attachment 3: shar, Jan 13, seems to replace port.

It would help this PR along if:

1) all unnecessary attachments are designated "obsolete" so they get hidden and
don't add to confusion.
2) Make sure patches to the port itself are present.
3) most importantly: poudriere logs for every platform to verify this port
builds on all advertised platforms. I see "internal testing" is implied, but
we want to see external testing, e.g. poudriere for verification purposes.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #10 from Xin LI <***@FreeBSD.org> ---
(In reply to andy zhang from comment #8)
Hi, Andy,

I have noticed that the port have changed to a way where two new scripts,
loader.sh and unloader.sh were added, and in pkg-install/pkg-deinstall scripts,
they were mentioned.

Is it possible to collapse the functionality into pkg-install/pkg-deinstall?
This would be helpful for those who use pkg(8) only without a ports tree (as
the scripts were not distributed as part of the port). If the scripts make
changes to the base system, they can also be packaged instead (e.g. install to
/usr/local/share/hyperv/ or /usr/local/libexec/hyperv/) so that users who
install binary package would get these scripts too.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #11 from Xin LI <***@FreeBSD.org> ---
@FangJun -- There are a few issues with the patch ("patch (35.41 KB, patch)
2014-12-23 05:36 UTC"). Could you please check?

1) src/sys/dev/hyperv/utilities/hv_util.c: in tree driver should never return
BUS_PROBE_VENDOR. Otherwise vendor supplied driver will not take precedence.

I would recommend making a (git or your source code management tool) branch for
in-tree driver submission to make it easier for future merge, etc., as the SCM
tool would take care for this kind of differences.

2) same file -- the driver name have been changed from "hyperv-utils" to
"hyperv-utils-port", is this intentional? (I think it's not but it's ok if it's
intentional).

3) hyperv_support.S is missing in the patch. Please use use '-N' when
generating the diff.

I can make minor corrections manually. If the changes would be larger please
generate a new diff.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #12 from FangJun <***@hotmail.com> ---
(In reply to Xin LI from comment #11)
@Xin, thanks for your comments.

1) In the built-in code, hv_util.c probe() still return BUS_PROBE_DEFAULT. We
only use BUS_PROBE_VENDOR with the hyperv-is ports to enable our vendor
supplied driver.

2) We use the name "hyperv-utils-port" is intentionally, because it is weird
that the loader cannot load the hv_utils.ko but it is OK to load other hyperv
modules(eg. hv_storvsc.ko). For example, we modify the /boot/loader.conf as
below:
hv_storvsc_load="YES"
hv_utils_load="YES"

And then reboot system, we can find only storvsc can be loaded:
/boot/kernel/kernel text=0xf8f898 data=0x124a30+0x2055c0
syms=[0x8+0x1405e0+0x8+0x15b077]
/boot/kernel/hv_storvsc.ko size 0x6278 at 0x1956000
Booting...

And if we change the name, such as hv_utils_test.ko, hv_utils can be loaded
successfully. @Xin, ao you have any advice?
For this reason and in ooder to allow the user to know the ports is in use, we
also change hv_storvsc.ko to hv_storvsc_ports.ko.

3) The hyperv_support.S will not be used this time, we will delete it.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #13 from Kylie <***@microsoft.com> ---
Xin and John,

Could you please review Jun's reply? Any advice for point 2?

2) We use the name "hyperv-utils-port" is intentionally, because it is weird
that the loader cannot load the hv_utils.ko but it is OK to load other hyperv
modules(eg. hv_storvsc.ko).

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196185

--- Comment #14 from John Marino <***@FreeBSD.org> ---
I am really not suitable to lead this PR.
I primary run DragonFly and don't use FreeBSD as much as most of the other
committers. Before I was mainly assisting a PR that had been stuck for ages.

That said, if changing the name of the module allows it to load, something
else is going on. That doesn't sound right to me.